Great, thanks! Will do after I fix up your bits. Out for a bit but will get this in the afternoon.
On Tue, Sep 29, 2015 at 12:53 PM, Zachary Turner <ztur...@google.com> wrote: > Unless you make significant other changes, feel free to just commit. I > don't have any other concerns. Thanks for working on this! > > On Tue, Sep 29, 2015 at 12:51 PM Todd Fiala <todd.fi...@gmail.com> wrote: > >> tfiala added a comment. >> >> > Does that look right to you? >> >> >> That result looks right - the two soft terminate tests get skipped when >> it's not reported. >> >> If you ran the lldb test suite with that setup, they should work as well >> as they did before the change. (If they don't, I'm missing a lower level >> test). >> >> I'll fix up those other parts you called out and get what is hopefully >> the final patch up. >> >> >> http://reviews.llvm.org/D13124 >> >> >> >> -- -Todd
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
