brucem created this revision.
brucem added reviewers: clayborg, jingham, jhibbits, emaste.
brucem added a subscriber: lldb-commits.
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* code was added and weren't
used at the time. The review for the commit that added them can be
found at http://reviews.llvm.org/D5988
The commit comment notes that backtraces don't yet work:
Backtraces don't work. This is due to PowerPC ABI using a
backchain pointer in memory, instead of a dedicated frame
pointer register for the backchain.
So there is a possibility these were added with the intent of using
them in the future.
http://reviews.llvm.org/D13506
Files:
source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
Index: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===================================================================
--- source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
- virtual bool
- StackUsesFrames ()
- {
- return true;
- }
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
- virtual bool
- FunctionCallsChangeCFA ()
- {
- return true;
- }
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------
Index: source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===================================================================
--- source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
- virtual bool
- StackUsesFrames ()
- {
- return true;
- }
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
- virtual bool
- FunctionCallsChangeCFA ()
- {
- return true;
- }
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------
Index: source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
===================================================================
--- source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
+++ source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
- virtual bool
- StackUsesFrames ()
- {
- return true;
- }
-
// The SysV ppc64 ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
- virtual bool
- FunctionCallsChangeCFA ()
- {
- return true;
- }
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------
Index: source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
===================================================================
--- source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
+++ source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
@@ -62,12 +62,6 @@
virtual bool
RegisterIsVolatile (const lldb_private::RegisterInfo *reg_info);
- virtual bool
- StackUsesFrames ()
- {
- return true;
- }
-
// The SysV ppc ABI requires that stack frames be 16 byte aligned.
// When there is a trap handler on the stack, e.g. _sigtramp in userland
// code, we've seen that the stack pointer is often not aligned properly
@@ -97,12 +91,6 @@
return true;
}
- virtual bool
- FunctionCallsChangeCFA ()
- {
- return true;
- }
-
virtual const lldb_private::RegisterInfo *
GetRegisterInfoArray (uint32_t &count);
//------------------------------------------------------------------
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
