zturner added a comment.

I guess this is ok.  I don't like raising the `None` check outside the 
function, but I don't see another way that isn't more convoluted.

However, I think you still need to fix the grouping of the parentheses.  the 
`compiler is None` should not override the version check.


http://reviews.llvm.org/D14673



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to