ovyalov added a comment. Please see my comments.
================ Comment at: packages/Python/lldbsuite/test/lldbtest.py:464 @@ -463,3 +463,3 @@ parsed_url = urlparse.urlparse(lldb.platform_url) - if parsed_url.scheme == "adb": + if parsed_url.scheme in ["adb", "unix-abstract-connect"]: device_id = parsed_url.netloc.split(":")[0] ---------------- I think in case of Android we can always treat result of parsed_url.netloc.split(":")[0] as a device id unless it's set to 'localhost' - it should hold true for any protocol scheme. ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:64 @@ -63,3 +63,3 @@ if lldb.platform_url: - scheme, host = re.match('(.+)://(.+):\d+', lldb.platform_url).groups() - if scheme == 'adb': + if lldb.platform_url.startswith('unix-abstract-connect'): + url_pattern = '(.+)://\[?(.+?)\]?/.*' ---------------- You may use "unix-" to allow regular domain sockets as well. ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:69 @@ -66,1 +68,3 @@ + scheme, host = re.match(url_pattern, lldb.platform_url).groups() + if scheme in ['adb', 'unix-abstract-connect']: self.stub_device = host ---------------- if host != 'localhost' ? http://reviews.llvm.org/D14765 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits