tberghammer added inline comments.
================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:201-204
@@ -205,7 +200,6 @@
- if lldb.remote_platform:
- dylibName = os.path.join(shlib_dir, 'libloadunload_a.so')
- elif self.platformIsDarwin():
+ if self.platformIsDarwin():
dylibName = 'libloadunload_a.dylib'
else:
dylibName = 'libloadunload_a.so'
+
----------------
clayborg wrote:
> It would be great to add something to lldb::SBPlatform and
> lldb_private::Platform that allows us to get the shared library extension
> from the platform:
>
> ```
> class SBPlatform
> {
> const char *
> GetSharedLibraryExtension();
> };
> ```
>
> Then this code can become:
>
> ```
> dylibName = "libloadunload" + platform.GetSharedLibraryExtension()
>
>
It is a fairly unrelated change. Will create a separate CL for it
================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:206-209
@@ +205,6 @@
+
+ if lldb.remote_platform:
+ dylibPath = os.path.join(shlib_dir, 'libloadunload_a.so')
+ else:
+ dylibPath = dylibName
+
----------------
clayborg wrote:
> This code should be:
>
> ```
> if lldb.remote_platform:
> dylibPath = os.path.join(shlib_dir, dylibName)
> else:
> dylibPath = dylibName
> ```
Done
http://reviews.llvm.org/D11465
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
