clayborg added a comment.

Be sure to add nice HeaderDoc to the LoadImage() declaration in Platform.h so 
everyone knows what is expected. We still might want to split this up so that 
only Platform has LoadImage and we make everyone else just implement:

  virtual uint32_t DoLoadImage(lldb_private::Process* process, const FileSpec& 
image_spec, Error& error);

These functions would _only_ load the native "image_spec", but the 
Platform::LoadImage() would take care of all of the common code that checks the 
two FileSpec parameters and installs the stuff if needed, then calls through to 
the DoLoadImage() in subclasses.

How does that sound?


http://reviews.llvm.org/D15152



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to