tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

Hey Zachary,

As best as I can tell, we don't need to do anything here, at least not on OS X 
El Capitan, because six is already included in the OS X Python distribution.

I was scratching my head for a while to figure out why, but that seems to be it.

I'd be okay with leaving this as is without any Xcode change.  I will be 
cleaning up the "finish" step of the python script handling, much like I did 
for the front end a few weeks ago.  When I do that, Xcode will switch to the 
finisher, and will pick up the "lldb official" in-repo version of six we're 
using.  I'd rather not create the extra work of addressing "which six" at this 
point given that other pending work.

All the tests run on a clean build after with no new errors.  (OS X right now 
seems to have one error and one failure on a clean public system at this point, 
but that is not a result of this change).  I also exercised the in-lldb script 
handling and that seemed to be working.


http://reviews.llvm.org/D15209



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to