tberghammer added inline comments.
================
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:597
@@ +596,3 @@
+ {
+ if (base_type.IsFloatingPointType(float_count, is_complex))
+ {
----------------
omjavaid wrote:
> tberghammer wrote:
> > What is float_count means here? Do we have to check its value to decide if
> > we can print the return value (e.g. what happens when float_count == 2)?
> float_count is just used to fullfil argument requirements. It was already
> declared in the function so didnt have to define it here.
>
> It returns 1 if type is a standard builtin type (float or double), returns 2
> for complex and number of elements for vector types.
>
> We are using homogeneous_count to tell the number of elements in our
> aggregate type.
In that case I think we should check that its value after the call is 1 because
we don't want to use the current implementation for vector types (we already
check for complex types)
http://reviews.llvm.org/D16975
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
