labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.

The actual changes aren't too bad, but I wonder why you need to add them at 
all. These files all assume they will be running on a linux host (they are a 
part of lldb-server), and they will not do anything useful even if you can get 
them to compile. I am not sure what is the state of the xcode build, but in 
cmake we don't even compile the whole folder on other platforms (see 
`source/Plugins/Process/CMakeLists.txt`). I wonder if you should do the same 
for your build system (?)


Repository:
  rL LLVM

http://reviews.llvm.org/D17750



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to