clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626
@@ -1624,4 +1624,4 @@
if (arch_spec.GetMachine() == llvm::Triple::mips ||
arch_spec.GetMachine() == llvm::Triple::mipsel
|| arch_spec.GetMachine() == llvm::Triple::mips64 ||
arch_spec.GetMachine() == llvm::Triple::mips64el)
{
----------------
Should we add a function like:
```
bool ArchSpec::IsMIPS() const;
```
Every patch I see for MIPS has these same four machine checks. If we add
another we will need to update all places that do this..
Repository:
rL LLVM
http://reviews.llvm.org/D18858
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
