labath added a comment.

I like the idea of having a centralized place defining "invalid characters". 
However, I am not sure if that needs to be (at least in this case) 
system-dependent. Since presumably the code will need to work on all platforms 
anyway, having the escaping done in a divergent manner will just complicate 
testing. I don't see a reason to not define the illegal characters as a union 
of illegal characters across all platforms (which basically means, using the 
windows set).


http://reviews.llvm.org/D20548



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to