labath added a subscriber: labath.
================
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505
@@ +496,11 @@
+ {
+ bool fre;
+ bool fr1;
+ IsFR1_FRE (fr1, fre);
+
+ // fr1 fre fpu_reg_size
+ // 1 0 64
+ // 1 1 32
+ // 0 0 32
+ reg_info->byte_size = (fr1 ^ fre) ? 8 : 4;
+ }
----------------
nitesh.jain wrote:
> clayborg wrote:
> > If we don't add anything to RegisterInfo, then this code is fine. Else we
> > will need to check "reg_info->dynamic_size_dwarf_expr_bytes" and evaluate
> > the DWARF expression to get the size.
> If Dwarf expression need to be evaluate at server side, then we need to add
> one more function in DWARFExpression::Evaluate to take NativeRegisterContext
> has a parameter. So should I add one more functionality in it ?
>
> Thanks
Please be careful about pulling more code to lldb-server, as it may cause the
size to blow up due to transitive dependencies. If you're going to do that,
please check the impact on the binary size, but I think it would be best to
keep dwarf expression evaluation out of the server altogether.
Repository:
rL LLVM
http://reviews.llvm.org/D20357
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
