zturner added a comment. You mention a `StringRefExtractor`. But nothing about `StringExtractor` that I can tell depends on the fact that it's null terminated. It only needs to know where to stop. A `StringRef` contains a length, so you stop when it gets to the end of the `StringRef`. It seems to me like we don't need a `StringRefExtractor`, but rather that `StringExtractor` itself can just be updated to use a `StringRef` instead of a `std::string`.
Anyway, I will try to whip up a patch that converts `StringExtractor` to store a `StringRef` internally. I'll put it up for review when I'm done just so you can see what I have in mind. If it works great, if it doesn't oh well :) https://reviews.llvm.org/D23884 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
