nitesh.jain added inline comments.

================
Comment at: 
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:131
@@ +130,3 @@
+
+    GDBRemoteClientBase::Lock lock(gdb_comm, false);
+    if (!lock)
----------------
Hi labath,

This patch cause deadlock when we try to run "reg read f0".  The 
GDBRemoteRegisterContext::ReadRegister is call twice which result in deadlock 
since earlier acquire lock has not been release.

1) To Evaluate Dwarf expression so that floating register size can be determine 
at run time. It add overhead of reading one more register which cause lock to 
acquire and forgot to release at the end.

2) To read register f0. This time it try to acquire lock which is not been 
release resulting in deadlock.

-NJ




Repository:
  rL LLVM

https://reviews.llvm.org/D23802



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to