Thanks for the review Zachary, but I don’t have commit privileges, so I hope that someone can commit the change for me.
From: Zachary Turner <ztur...@google.com> Date: Tuesday, August 30, 2016 at 6:52 PM To: "reviews+d24064+public+13175c1cba5ef...@reviews.llvm.org" <reviews+d24064+public+13175c1cba5ef...@reviews.llvm.org>, Taras Tsugrii <ttsug...@fb.com> Cc: "lldb-commits@lists.llvm.org" <lldb-commits@lists.llvm.org> Subject: Re: [PATCH] D24064: Fix lldb build on Mac. Looks good, feel free to commit without review when you're fixing a build On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii <ttsug...@fb.com<mailto:ttsug...@fb.com>> wrote: wttsugrii created this revision. wttsugrii added a reviewer: zturner. wttsugrii added a subscriber: lldb-commits. https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308 greatly improved an API, but missed one more occurence of legacy usage. This leads to: if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size()) ~~~~~~~~~~~~~~~~~~~~~ ^~~~~~ /lldb/include/lldb/Utility/StringExtractor.h:151:5: note: 'GetHexBytes' declared here https://reviews.llvm.org/D24064<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D24064&d=DQMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=jqaYv5aDYHR_MGTz1rkWPg&m=C_-Mt0Q6SBVqzxYJUNfPoBSJcuoC80sFiVFMleZ6laQ&s=gS55VX9ND45mrFYZFa0QZPP3ZA26W7uq8U_m4wUlq_Q&e=> Files: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp =================================================================== --- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp +++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp @@ -1099,7 +1099,7 @@ return false; } payload_bytes.resize(ascii_hex_bytes_cstr_len/2); - if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size()) + if (extractor.GetHexBytes(payload_bytes, '\xdd') != payload_bytes.size()) { result.AppendErrorWithFormat ("payload data must only contain ASCII hex characters (no spaces or hex prefixes): '%s'", ascii_hex_bytes_cstr); result.SetStatus (eReturnStatusFailed);
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
