labath added a comment. I think we're approaching the end now. If you could upload the new version (you'll have to reformat the changes), I'll give it a final pass.
================ Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6 @@ +5,3 @@ +ifeq "$(ARCH)" "i386" + CFLAGS_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32 + LD_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32 ---------------- valentinagiusti wrote: > You are right, if I use CFLAGS_EXTRAS I don't have to check for the arch or > use LD_EXTRAS. I wish I knew this from the beginning... Yeah, I don't blame you. :) The test suite is not an easy thing to wrap your head around. I am sorry if some of my comments sounded a bit harsh. https://reviews.llvm.org/D24255 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits