slydiman wrote:

> But do both of those callers need the "optional launch" functionality? AIUI, 
> it's only the Handle_qLaunchGDBServer that does, and the code in 
> lldb-platform.cpp should launch a server unconditionally.

We can launch gdbserver with tcp protocol only after accepting the connection.
lldb-platform.cpp calls GDBRemoteCommunicationServerPlatform::LaunchGDBServer() 
when
1. Accept the gdb connection (fd is known).
2. At the beginning if additional parameters provided after `--`. 
fd=kInvalidFD. It is a `pending` GdbServer.

https://github.com/llvm/llvm-project/pull/104238
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to