Not done building yet, I also had to fetch a new llvm, but at least those were needed.
Jim > On Sep 23, 2016, at 3:47 PM, Zachary Turner <ztur...@google.com> wrote: > > Ahh nvm, I see you beat me to it. Thanks > > On Fri, Sep 23, 2016 at 3:47 PM Zachary Turner <ztur...@google.com> wrote: > Thanks I'll take a look. I only saw the other because I got a buildbot break > notification. I'll go checkout Host.mm > > On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham <jing...@apple.com> wrote: > I think you missed some changes in Host.mm on OS X as well. > > Jim > > > On Sep 23, 2016, at 3:27 PM, Zachary Turner via lldb-commits > > <lldb-commits@lists.llvm.org> wrote: > > > > Author: zturner > > Date: Fri Sep 23 17:27:03 2016 > > New Revision: 282309 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=282309&view=rev > > Log: > > Fix build on Ubuntu. > > > > This was in some code that was #ifdef'd out on Windows, so I > > didn't see it. > > > > Modified: > > lldb/trunk/source/Host/common/Host.cpp > > > > Modified: lldb/trunk/source/Host/common/Host.cpp > > URL: > > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Host.cpp?rev=282309&r1=282308&r2=282309&view=diff > > ============================================================================== > > --- lldb/trunk/source/Host/common/Host.cpp (original) > > +++ lldb/trunk/source/Host/common/Host.cpp Fri Sep 23 17:27:03 2016 > > @@ -942,15 +942,15 @@ bool Host::AddPosixSpawnFileAction(void > > if (oflag & O_CREAT) > > mode = 0640; > > > > - error.SetError( > > - ::posix_spawn_file_actions_addopen(file_actions, info->GetFD(), > > - info->GetPath(), oflag, mode), > > - eErrorTypePOSIX); > > + error.SetError(::posix_spawn_file_actions_addopen( > > + file_actions, info->GetFD(), > > + info->GetPath().str().c_str(), oflag, mode), > > + eErrorTypePOSIX); > > if (error.Fail() || log) > > error.PutToLog(log, "posix_spawn_file_actions_addopen (action=%p, " > > "fd=%i, path='%s', oflag=%i, mode=%i)", > > static_cast<void *>(file_actions), info->GetFD(), > > - info->GetPath(), oflag, mode); > > + info->GetPath().str().c_str(), oflag, mode); > > } > > break; > > } > > > > > > _______________________________________________ > > lldb-commits mailing list > > lldb-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
