https://github.com/jasonmolenda approved this pull request.
Sorry I wasn't sure if Greg or David had further comments/questions so I didn't touch it. This looks good to me. The one question I had is in a few places where you construct a Function (`std::make_shared<Function>...`) we pass the base address and size, and I'm not clear (in most cases) if the size is the maximum size of all ranges (the span between the lowest address and highest address in any range) in the function, or only the size of the first address range. If it's the maximum size of all ranges, that means we'll have compile units with overlapping address ranges, won't it? Is this a problem? https://github.com/llvm/llvm-project/pull/122440 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
