labath added a comment.

Comment at: 
+  if (source_data.size() < sizeof(MinidumpContext_x86_64))
+    return result_context_buf;
This looks like error handling. Should we return an empty buffer in that case 
(so that the caller can see that we actually failed in parsing this)?

Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h:141
+      uint128_struct legacy[8];
+      uint128_struct xmm0;
+      uint128_struct xmm1;
`uint128_struct xmm[16];` ?

I'm not that sure about that struct and it's name though, I'll need to think 
about that.

lldb-commits mailing list

Reply via email to