Today I checked out lldb to check that r284364 wouldn't cause any
trouble, but there were a few warnings that fired when I tried to build
it, breaking my -Werror build.
This disables four character literal warnings (so that 'FDSC' in
debugserver.cpp is allowed) and pedantic formatting warnings, so that
printf-like functions can pass typed pointers to "%p" in format strings.
Okay to commit?
commit c45c40c7fb8d6cff3234dc557376b513293d59cf
Author: Justin Bogner <m...@justinbogner.com>
Date: Sun Oct 16 21:38:58 2016 -0700
debugserver: Disable four-char-constants and format-pedantic warnings
diff --git a/tools/debugserver/source/CMakeLists.txt b/tools/debugserver/source/CMakeLists.txt
index 43479bd..621d64d 100644
--- a/tools/debugserver/source/CMakeLists.txt
+++ b/tools/debugserver/source/CMakeLists.txt
@@ -27,6 +27,18 @@ if (CXX_SUPPORTS_NO_EXTENDED_OFFSETOF)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-extended-offsetof")
endif ()
+check_cxx_compiler_flag("-Wno-four-char-constants"
+ CXX_SUPPORTS_NO_FOUR_CHAR_CONSTANTS)
+if (CXX_SUPPORTS_NO_FOUR_CHAR_CONSTANTS)
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-four-char-constants")
+endif ()
+
+check_cxx_compiler_flag("-Wno-format-pedantic"
+ CXX_SUPPORTS_NO_FORMAT_PEDANTIC)
+if (CXX_SUPPORTS_NO_FORMAT_PEDANTIC)
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-format-pedantic")
+endif ()
+
if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
add_definitions(
-DDEBUGSERVER_VERSION_STR="${LLDB_VERSION}"
@@ -65,4 +77,3 @@ if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
target_link_libraries(lldbDebugserverCommon ${COCOA_LIBRARY})
add_subdirectory(MacOSX)
endif()
-
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
