================
@@ -698,14 +697,22 @@ llvm::json::Value CreateSource(llvm::StringRef
source_path) {
return llvm::json::Value(std::move(source));
}
-static std::optional<llvm::json::Value> CreateSource(lldb::SBFrame &frame) {
+static llvm::json::Value CreateSource(lldb::SBFrame &frame,
----------------
JDevlieghere wrote:
I assume this function is used elsewhere? The line number and column have a
different meaning based on whether we have source info and having the logic
spread across this function and `CreateStackFrame` seems like a pretty big foot
gun. Any chance we can localize this logic?
https://github.com/llvm/llvm-project/pull/128268
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
