beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed.
`LLDB_PATH_TO_LLVM_BUILD` is a swift-ism that doesn't match LLVM's CMake conventions. In LLVM we don't pass in the path to build directories, instead we pass in `LLVM_CONFIG` to standalone builds, and we derive the build directory from the output of `llvm-config`. Passing in `LLVM_CONFIG` is more flexible, robust, and consistent with how other LLVM subprojects work, and I see no reason to change that convention. Repository: rL LLVM https://reviews.llvm.org/D25830 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
