ashgti wrote:

> What is your overall plan for this PR?
> 
> I assume the first step is to get buy-in from all reviewers into the new 
> structure for our JSON types. But what comes after? Are you planning to 
> update this PR to cover all JSON types / requests / responses? Are you 
> planning to land this PR for the `Source*` types only (as currently in 
> review) and do the remaining types in follow-up PRs?
> 
> (Both approaches would be fine by me. Just trying to understand the approach, 
> so I know when it's time to hit the "Approve" button 😉)

I was thinking of doing this more incrementally. I was planning to build on 
this for handling the 'cancel' request first but then I'd like to follow up 
with requests to use the new explicit types for handling arguments and 
responses.

https://github.com/llvm/llvm-project/pull/130090
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to