https://github.com/labath approved this pull request.
> So, I will move LoadPlugin lambda to SystemInitializerFull. Thanks, this LGTM now, but do wait for @JDevlieghere's review as well. > Note lldbInitialization depends on lldbPluginProcessGDBRemote, > lldbPluginProcessPOSIX and lldbPluginProcessWindowsCommon. > SystemInitializerCommon::Initialize() calls > process_gdb_remote::ProcessGDBRemoteLog::Initialize(), > ProcessPOSIXLog::Initialize() and ProcessWindowsLog::Initialize(). If it is > OK for Utility, I will move lldbInitialization into lldbUtility. Ah yes, I'm not sure how I missed these, but that explains why these are a separate library. These deps aren't OK for Utililty, though I am not sure they actually need to be here. I think the log classes should be initialized from their respective plugins' `Initialize` methods. It also calls FileSystem and HostInfo initialization functions, which also aren't OK, but maybe we could do something about these too (in particular, we already need to jump through some hoops in order to pass arguments into HostInfo::Initialize). I may have some time to do some "casual coding" next week, so I'll try to come up with something here. > I would prefer to move lldbInitialization into lldbUtility with a separate > patch. definitely https://github.com/llvm/llvm-project/pull/134383 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
