labath wrote: > > We have a tests for this function in `unittests/Host/linux/HostTest.cpp` > > and it looks like at least some of it should apply to other systems as > > well. We could move it to the "posix" folder so that it applies to your > > code as well. Depending on the size of linux-specific parts, we could > > either keep them in the "linux" folder, or `#ifdef` them out > > Okay, we will create new PR to either move it to posix or we can create > `HostTest.cpp` for aix separately. @labath or you want me to drop the > testcase changes in same PR ?
Let's do that here. The PR is small (as it should be) and it's good to have tests together with the code being tested. https://github.com/llvm/llvm-project/pull/134354 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
