[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

[Jacob Lalonde via lldb-commits]

================
@@ -1217,28 +1217,36 @@ 
PluginManager::GetSymbolLocatorCreateCallbackAtIndex(uint32_t idx) {
 }
 
 ModuleSpec
-PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec) {
+PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec,
+                                          std::string *locator_name) {
   auto instances = GetSymbolLocatorInstances().GetSnapshot();
   for (auto &instance : instances) {
     if (instance.locate_executable_object_file) {
       std::optional<ModuleSpec> result =
           instance.locate_executable_object_file(module_spec);
-      if (result)
+      if (result) {
----------------
Jlalond wrote:

would it be cleaner/easier to do `if(!result) return {};` as a guard clause to 
have less nested ifs?

https://github.com/llvm/llvm-project/pull/134563
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits