jasonmolenda wrote:

Maybe I'm missing something, but I disagree with this change. We're talking 
about when you're stopped in a stack frame that has debug info (a file and line 
number), but the source file is unavailable, right.  There is a setting to 
control this behavior already -- `stop-disassembly-display`.  It defaults to 
`no-debuginfo`, but it can be `never`, `always`, `no-source`, or 
`no-debuginfo`.  

People who are debugging at a source level, generally, do not want to see 
assembly, and in fact will be confused if they are shown assembly.  We do not 
want to show assembly for a stack frame where we have a debug filename and line 
number, by default.  The user may not have set up the target.source-map to map 
lldb to the source file, and could be looking at it in another source window as 
they're stepping, or they may know roughly how many lines a method has as they 
step through it.  The assembly only adds distraction to them.

Am I misunderstanding what we're talking about here?

https://github.com/llvm/llvm-project/pull/136494
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to