dyung wrote: > The original PR (#115331) was approved and merged, but later reverted due an > unstable test. The only difference in this version of the PR was a fix to > make the test stable on Windows, so I thought it would be ok to merge by the > approval of the original PR. Apologies if I was mistaken on this.
Who approved the original PR? Was the approval done offline? I do not see an approval in the original PR, just some feedback. https://github.com/llvm/llvm-project/pull/136121 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits