jasonmolenda wrote: Today we add a made up name, `___lldb_unnamed_symbol<magic numbers>` using an ordinal that increases for each Module. The only thing special about the ordinal is that it is repeatable if lldb is run on the same binary. Using file addresses for that ordinal would give that same result. We are changing from a base 10 ordinal to a base16 ordinal, but given that the numbers themselves are arbitrary, I'm sure no one is parsing them.
I think this change is fine, but I agree I wouldn't bother with a setting. Both approaches achieve the most important goal - having the same synthetic names when lldb is re-run on the same binary - and there's one use case where having it based on a file address helps that workflow. I'd change lldb to use the file addresses. https://github.com/llvm/llvm-project/pull/137512 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
