Michael137 wrote: > For the way you're using these files (as a gtest unit test), I think it'd be > best if the tests were in `llvm/include/llvm/Testing/Demangle`.
Let me try proposing moving the test and see what they say. Making changes to the demangler you have to run two sets of test-suites already anyway (`check-cxxabi` and `check-llvm-demangle`, and there's other demangling tests sprinkled around llvm). Just having to run one target would be nice. > Just a note, that if you do decide to copy the tests, it may be better to > just copy the inputs (mangled names) and then compare the "normal" demangled > names with the ones you reconstructed. This avoids needing to update two > places in case e.g. the demangler produces extra spaces somewhere. Good point, will do! https://github.com/llvm/llvm-project/pull/137793 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
