================
@@ -213,6 +213,11 @@ static bool GetStatusInfo(::pid_t Pid, ProcessInstanceInfo
&ProcessInfo,
} else if (Line.consume_front("Tgid:")) {
Line = Line.ltrim();
Line.consumeInteger(10, Tgid);
+ } else if (Line.consume_front("CoreDumping:")) {
+ uint32_t coredumping;
+ Line = Line.ltrim();
+ Line.consumeInteger(1, coredumping);
----------------
DavidSpickett wrote:
This is calling:
```
template <typename T> bool consumeInteger(unsigned Radix, T &Result) {
```
* Radix of 1 means binary?
* Parsing can fail, though now I look above and nothing else checks the return
value, sigh...
This is new though, so can you make it check the return value and not set if
it's false? The type is optional<bool>, so anyone making use of this is
handling the "I don't know" state already.
https://github.com/llvm/llvm-project/pull/138580
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
