================
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr<FileManager> FileMgr;
+ std::unique_ptr<DiagnosticOptions> DiagOpts;
----------------
ojhunt wrote:
I don't like that in some cases we have a unique_ptr<DiagnosticOptions> and
later (ATSUnit) we use a shared_ptr<>. It leaves an author unable to know given
some arbitrary DiagnosticOptions* what the lifetime and/or ownership rules are.
https://github.com/llvm/llvm-project/pull/139584
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
