JDevlieghere wrote:

Summarizing the problem to make sure I understand: with the new launch/attach 
flow, we set the breakpoints in the dummy target before the actual target is 
created. If the target is created through launch commands, we're calling 
SetTarget with the currently selected target. By that time, we've already 
missed events belong to the new target. 

With this PR, we mimic what the default event handler does, which is listen to 
all target events. I think the problem with this approach is that now we're 
going to be broadcasting events for targets that are not the focus of the 
current debug session (i.e. the selected target). It should be easy to verify 
this by running a script that creates a second target and seeing if we now 
broadcast the events. If my theory is correct, then we would have to filter 
events not belonging to the selected target. 

Interestingly, I was thinking about multi-target/multi-process support in DAP 
earlier this week. I had someone reach out to ask questions about this. I'll 
file an issue to track this, but we should keep that use case in mind as we 
design this.

https://github.com/llvm/llvm-project/pull/140142
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to