[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

[Jonas Devlieghere via lldb-commits]

================
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments 
&args) const {
     }
   }
 
+  int64_t instructionOffset = args.instructionOffset.value_or(0);
----------------
JDevlieghere wrote:

Maybe add a comment saying that this is the _number_ of instructions. 
```suggestion
  // Offset (in instructions) to be applied after the byte offset (if any) 
before disassembling. Can be negative.
  int64_t instruction_offset = args.instructionOffset.value_or(0);
```

https://github.com/llvm/llvm-project/pull/140486
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits