================
@@ -131,9 +133,10 @@ def verify_breakpoint_hit(self, breakpoint_ids, 
timeout=DEFAULT_TIMEOUT):
                 # So when looking at the description we just want to make sure
                 # the right breakpoint matches and not worry about the actual
                 # location.
+                type_name = "watchpoint" if is_watchpoint else "breakpoint"
----------------
ashgti wrote:

I think according to the spec, the 'reason' on line 122 should be `data 
breakpoint`, which maybe means our stopped event handler isn't handling data 
breakpoints correctly.

On that note, in the DAP this would be a `data breakpoint` not a 'watchpoint', 
can we update the description accordingly?

https://github.com/llvm/llvm-project/pull/141122
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to