Jlalond wrote: > Now for tests. The tests for the UnixSignals part are great, but I'm not sure > if there's a test for the end-to-end flow. It possible this automatically > code is tested by one of the existing core file. Could you check if anything > breaks if you e.g. change GetDescriptionFromSiginfo to return an empty > string? If it does, then it's probably fine. If not, could you check if one > of our existing core files has the siginfo stuff we'd need to write a test > for this?
Yep! I broke basically every core test on my 5th commit, plenty of shell tests that cover this and I ensured I maintained the existing behavior. https://github.com/llvm/llvm-project/pull/140150 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
