Author: Jason Molenda Date: 2025-05-27T21:50:56-07:00 New Revision: 7c471e12c80f86ba089fb5951ece4d516996d9a1
URL: https://github.com/llvm/llvm-project/commit/7c471e12c80f86ba089fb5951ece4d516996d9a1 DIFF: https://github.com/llvm/llvm-project/commit/7c471e12c80f86ba089fb5951ece4d516996d9a1.diff LOG: [lldb][NFC] This test is marked expectedfail for macos version less-than-14.4. Our CI bot is running macOS 14.1 but I still see FAILs from this text in the CI logs? It may be that the CI is really seeing TestTemplateWithSameArg.py fail and is highlighting this XFAIL test even though it's expected. But I'm not interested enough, I'll try just skipping it altogether on < macOS 14.4. This does mean I'm skipping it on intel where the kernel never had the issue involved. Added: Modified: lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py Removed: ################################################################################ diff --git a/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py b/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py index 199a066f30016..8179d5288ce8e 100644 --- a/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py +++ b/lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py @@ -19,11 +19,8 @@ def get_to_start(self, bkpt_text): return (target, process, thread, frame, read_watchpoint) @add_test_categories(["basic_process"]) - @expectedFailureAll( - macos_version=["<", "14.4"], - archs=["aarch64", "arm$"], - bugnumber="<rdar://problem/106868647>", - ) + # kernel disables wp's over instruction step, fixed in macOS 14.4. + @skipIf(macos_version=["<", "14.4"]) def test_step_over_read_watchpoint(self): self.build() target, process, thread, bkpt = lldbutil.run_to_source_breakpoint( @@ -62,11 +59,8 @@ def test_step_over_read_watchpoint(self): self.step_inst_for_watchpoint(1) @add_test_categories(["basic_process"]) - @expectedFailureAll( - macos_version=["<", "14.4"], - archs=["aarch64", "arm$"], - bugnumber="<rdar://problem/106868647>", - ) + # kernel disables wp's over instruction step, fixed in macOS 14.4. + @skipIf(macos_version=["<", "14.4"]) def test_step_over_write_watchpoint(self): self.build() target, process, thread, bkpt = lldbutil.run_to_source_breakpoint( _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
