Author: Jason Molenda Date: 2025-05-29T01:30:02-07:00 New Revision: 57f3151a3144259f4e830fc43a1424e4c1f15985
URL: https://github.com/llvm/llvm-project/commit/57f3151a3144259f4e830fc43a1424e4c1f15985 DIFF: https://github.com/llvm/llvm-project/commit/57f3151a3144259f4e830fc43a1424e4c1f15985.diff LOG: Revert "[lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)" The TestTemplateWithSameArg.py API test is crashing on macOS with this change. Michael is going to look into it; reverting for now to unblock the CI bots. This reverts commit 052c70451afb7323ef72f321f3b0b5abb024b302. Added: Modified: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp index c99ed9dd0a68d..eb62cb618f254 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp @@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module, auto file = HS.lookupModuleMapFile(*dir, is_framework); if (!file) return error(); - if (HS.parseAndLoadModuleMapFile(*file, is_system)) + if (!HS.parseAndLoadModuleMapFile(*file, is_system)) return error(); } } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
