DhruvSrivastavaX wrote: @labath > The code seems okay. I don't know anything about the format, so I don't know > which parts are "obvious" and which not, but I'd encourage you to add > comments where you think it might be useful.
Sure, I have added some comments for that now. > You're right that lldb-test doesn't dump symbols. You should be able to test > these changes with something like `lldb %t -o "image dump symtab"`, but if > you find that is missing some crucial piece of information, it would also be > fine to extend lldb-test to dump the data you need Yes, I had checked it using `image dump symtab` itself, my symbols do get added. As for the `lldb-test` not emitting symbols, I will create an issue for it so that we can start upgrading lldb-test as well. https://github.com/llvm/llvm-project/pull/141577 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
