Author: Dave Lee Date: 2025-05-30T13:28:51-07:00 New Revision: 7a80a8b2bc9136e5c6254eef68230a9b56b35779
URL: https://github.com/llvm/llvm-project/commit/7a80a8b2bc9136e5c6254eef68230a9b56b35779 DIFF: https://github.com/llvm/llvm-project/commit/7a80a8b2bc9136e5c6254eef68230a9b56b35779.diff LOG: [lldb] Remove some dead code in TypeSystemClang (NFC) (#142056) Added: Modified: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h Removed: ################################################################################ diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp index eb8271d46a043..c1917203b684c 100644 --- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp +++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp @@ -5302,16 +5302,12 @@ lldb::Format TypeSystemClang::GetFormat(lldb::opaque_compiler_type_t type) { return lldb::eFormatBytes; } -static bool ObjCDeclHasIVars(clang::ObjCInterfaceDecl *class_interface_decl, - bool check_superclass) { +static bool ObjCDeclHasIVars(clang::ObjCInterfaceDecl *class_interface_decl) { while (class_interface_decl) { if (class_interface_decl->ivar_size() > 0) return true; - if (check_superclass) - class_interface_decl = class_interface_decl->getSuperClass(); - else - break; + class_interface_decl = class_interface_decl->getSuperClass(); } return false; } @@ -5386,7 +5382,7 @@ TypeSystemClang::GetNumChildren(lldb::opaque_compiler_type_t type, class_interface_decl->getSuperClass(); if (superclass_interface_decl) { if (omit_empty_base_classes) { - if (ObjCDeclHasIVars(superclass_interface_decl, true)) + if (ObjCDeclHasIVars(superclass_interface_decl)) ++num_children; } else ++num_children; @@ -6840,7 +6836,7 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( if (ivar_decl->getName() == name_sref) { if ((!omit_empty_base_classes && superclass_interface_decl) || (omit_empty_base_classes && - ObjCDeclHasIVars(superclass_interface_decl, true))) + ObjCDeclHasIVars(superclass_interface_decl))) ++child_idx; child_indexes.push_back(child_idx); @@ -6996,7 +6992,7 @@ TypeSystemClang::GetIndexOfChildWithName(lldb::opaque_compiler_type_t type, if (ivar_decl->getName() == name) { if ((!omit_empty_base_classes && superclass_interface_decl) || (omit_empty_base_classes && - ObjCDeclHasIVars(superclass_interface_decl, true))) + ObjCDeclHasIVars(superclass_interface_decl))) ++child_idx; return child_idx; @@ -8117,14 +8113,6 @@ bool TypeSystemClang::AddObjCClassProperty( return true; } -bool TypeSystemClang::IsObjCClassTypeAndHasIVars(const CompilerType &type, - bool check_superclass) { - clang::ObjCInterfaceDecl *class_interface_decl = GetAsObjCInterfaceDecl(type); - if (class_interface_decl) - return ObjCDeclHasIVars(class_interface_decl, check_superclass); - return false; -} - clang::ObjCMethodDecl *TypeSystemClang::AddMethodToObjCObjectType( const CompilerType &type, const char *name, // the full symbol name as seen in the symbol table diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h index 285748719390c..b9e78cc377f04 100644 --- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h +++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h @@ -687,9 +687,6 @@ class TypeSystemClang : public TypeSystem { static bool IsObjCClassType(const CompilerType &type); - static bool IsObjCClassTypeAndHasIVars(const CompilerType &type, - bool check_superclass); - static bool IsObjCObjectOrInterfaceType(const CompilerType &type); static bool IsObjCObjectPointerType(const CompilerType &type, _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
