[Lldb-commits] [lldb] [LLDB] WIP: Add type summaries for MSVC STL strings (PR #143177)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- 
lldb/source/Plugins/Language/CPlusPlus/MsvcStl.cpp 
lldb/source/Plugins/Language/CPlusPlus/MsvcStl.h 
lldb/include/lldb/DataFormatters/StringPrinter.h 
lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp 
lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp 
lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.h 
lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.cpp 
b/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.cpp
index 8bb22cfe0..692047111 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.cpp
@@ -120,7 +120,7 @@ bool lldb_private::formatters::MsvcStlStringSummaryProvider<
 template <>
 bool lldb_private::formatters::MsvcStlStringSummaryProvider<
     StringElementType::UTF8>(ValueObject &valobj, Stream &stream,
-                              const TypeSummaryOptions &summary_options) {
+                             const TypeSummaryOptions &summary_options) {
   return MsvcStlStringSummaryProviderImpl<StringElementType::UTF8>(
       valobj, stream, summary_options, "u8");
 }
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.h 
b/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.h
index ffad55f13..c8f7b4027 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.h
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStl.h
@@ -9,8 +9,8 @@
 #ifndef LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_MSVCSTL_H
 #define LLDB_SOURCE_PLUGINS_LANGUAGE_CPLUSPLUS_MSVCSTL_H
 
-#include "lldb/DataFormatters/TypeSummary.h"
 #include "lldb/DataFormatters/StringPrinter.h"
+#include "lldb/DataFormatters/TypeSummary.h"
 #include "lldb/Utility/Stream.h"
 #include "lldb/ValueObject/ValueObject.h"
 
@@ -20,7 +20,8 @@ namespace formatters {
 template <StringPrinter::StringElementType element_type>
 bool MsvcStlStringSummaryProvider(
     ValueObject &valobj, Stream &stream,
-    const TypeSummaryOptions &summary_options); // VC 2015+ 
std::string,u8string,u16string,u32string
+    const TypeSummaryOptions
+        &summary_options); // VC 2015+ std::string,u8string,u16string,u32string
 
 bool MsvcStlWStringSummaryProvider(
     ValueObject &valobj, Stream &stream,

``````````

</details>


https://github.com/llvm/llvm-project/pull/143177
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits