Lgtm thanks On Tue, Dec 13, 2016 at 2:33 AM Hafiz Abid Qadeer via Phabricator < revi...@reviews.llvm.org> wrote:
> abidh created this revision. > abidh added a reviewer: zturner. > abidh added a subscriber: lldb-commits. > > This code was probably needed to support VS2013 and is not needed now. I > have built it with VS and mingw. Ok to remove it? > > > https://reviews.llvm.org/D27707 > > Files: > include/lldb/Host/windows/PosixApi.h > > > Index: include/lldb/Host/windows/PosixApi.h > =================================================================== > --- include/lldb/Host/windows/PosixApi.h > +++ include/lldb/Host/windows/PosixApi.h > @@ -75,15 +75,6 @@ > > #endif // _MSC_VER > > -// MSVC 2015 and higher have timespec. Otherwise we need to define it > -// ourselves. > -#if !defined(_MSC_VER) || _MSC_VER < 1900 > -struct timespec { > - time_t tv_sec; > - long tv_nsec; > -}; > -#endif > - > // Various useful posix functions that are not present in Windows. We > provide > // custom implementations. > int vasprintf(char **ret, const char *fmt, va_list ap); > @@ -113,20 +104,4 @@ > inline pid_t fork(void) { LLVM_BUILTIN_UNREACHABLE; } > inline pid_t setsid(void) { LLVM_BUILTIN_UNREACHABLE; } > > -// vsnprintf and snprintf are provided in MSVC 2015 and higher. > -#if _MSC_VER < 1900 > -namespace lldb_private { > -int vsnprintf(char *buffer, size_t count, const char *format, va_list > argptr); > -} > - > -// inline to avoid linkage conflicts > -int inline snprintf(char *buffer, size_t count, const char *format, ...) { > - va_list argptr; > - va_start(argptr, format); > - int r = lldb_private::vsnprintf(buffer, count, format, argptr); > - va_end(argptr); > - return r; > -} > -#endif > - > #endif > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
