zturner added inline comments.
================ Comment at: cmake/modules/LLDBConfig.cmake:246 +if (MSVC) + add_definitions( /D _UNICODE /D UNICODE ) +elseif (MINGW) ---------------- labath wrote: > Could you check if it's enough to pass `-DFOO` regardless of the platform. > This is the only usage of the `/D` version in the llvm codebase, which leads > me to believe that msvc will accept the `-D` version as well (or cmake will > somehow convert in for him. I think the -D syntax works on both, so I would change this back to the original condition, and just change the / to a - For example, right above this line you can see things like `-wd4150`, and right below this line you can see things like `-D_LARGEFILE_SOURCE` https://reviews.llvm.org/D27759 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
