https://github.com/labath approved this pull request.

Looks good. I don't think the test is very useful. Since all it tests is a 
negative, the test could be easily invalidated (e.g. by changing the error 
string), and we would never notice.

You can keep it if you want, but I'd be fine with this even without a test (on 
the account of us not testing log messages).

https://github.com/llvm/llvm-project/pull/144059
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to