Jlalond wrote:

> However, FileSpecList already has an AppendIfUnique method. So you could 
> (with less code than the current implementation) have all the new 
> lldb_private API's return what consumers actually want: an FileSpecList, and 
> then that would be trivially convertible to the SBFileSpecList, which is in 
> the end what you wanted to expose.


Good suggestion @jimingham, I also added a constructor to move a FileSpecList 
into the SBFileSpecList. The code is much cleaner now as you expected.

https://github.com/llvm/llvm-project/pull/144119
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to