bulbazord wrote: > @bulbazord I have a auggestion for this patch. I want to have the minimum > CMake necessary to let the tool build. To accomplish this, I want to take out > all code in this tool that relates to the server/client code, leaving the > code that generates the byproducts. I'd then shift the server code in > `lldb-rpc-gen.cpp` to the patch that's already up for the server emitter and > the client code for the patch for the client emitters. In effect: > > * This patch would have all RPCCommon code for lldb-rpc-gen > * `lldb-rpc-gen.cpp` will be stripped down to the code that generates the > byproducts (namely the class names, method names and skipped methods file) > * As mentioned above, the code in lldb-rpc-gen.cpp that relates to generating > the server code would move to the patch that's up for the server emitters. > * A test could be put up to just check that the byproducts files have been > emitted in their expected locations. > > I'd love to get your thoughts on this.
I say go for it. It would be a lot easier to review and you can introduce the server-side and client library generators incrementally. https://github.com/llvm/llvm-project/pull/138031 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
