================ @@ -742,6 +742,42 @@ bool fromJSON(const llvm::json::Value &, DisassembledInstruction &, llvm::json::Path); llvm::json::Value toJSON(const DisassembledInstruction &); +/// Arguments for `readMemory` request. +struct ReadMemoryArguments { + /// Memory reference to the base location from which data should be read. + std::string memoryReference; + + /// Offset (in bytes) to be applied to the reference location before reading + /// data. Can be negative. + std::optional<int64_t> offset; + + /// Number of bytes to read at the specified location and offset. + uint64_t count; +}; +bool fromJSON(const llvm::json::Value &, ReadMemoryArguments &, + llvm::json::Path); + +/// Response to `readMemory` request. +struct ReadMemoryResponse { + /// The address of the first byte of data returned. + /// Treated as a hex value if prefixed with `0x`, or as a decimal value + /// otherwise. + std::string address; + + /// The number of unreadable bytes encountered after the last successfully + /// read byte. + /// This can be used to determine the number of bytes that should be skipped + /// before a subsequent `readMemory` request succeeds. + std::optional<uint64_t> unreadableBytes; ---------------- ashgti wrote:
Can we default to 0 and make this not optional? https://github.com/llvm/llvm-project/pull/144552 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits