labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great, thanks.
Do you have any measurements on the real impact this makes on jModulesInfo
packet?
================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1757
+ // one memory region if memory region handling is supported.
+ if (m_mem_region_cache.empty()) {
+ Error error = ProcFileReader::ProcessLineByLine(
----------------
Please put an early return here:
`if (!cache.empty() { log_if_you_want_to(); return Error(); }`
https://reviews.llvm.org/D28233
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
