mstorsjo wrote: > truncate the section names, as [sections in PE/COFF executable images can't > be longer than 8 > bytes](https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#section-table-section-headers).
First off, this probably meant to say "section names can't be longer than 8 bytes", not the sections themselves. Then, this is on the level of nitpickery, but I think it's good to get the details right: If the names can't be longer than 8 bytes, then it would seem like it would be a hard limit that can't be overcome by using a different linker. As this is the PR description, which ends up as the commit message once this is merged, it's worth the effort to get the wording correct. Not sure what the best wording would be here, though... "Section names in PE/COFF executable images can't be longer than 8 bytes officially, although other linkers do support creating that, and GDB/LLDB do support reading longer names." Or something along those lines? And the same nuance for the warning message: > ``` > warning: (x86_64) foo.exe contains 5 truncated DWARF sections (.debug_a, > .debug_i, .debug_r, .debug_s, .debug_l). > Note: Executable images on Windows can't include the required names when > linking with the default link.exe. A third party linker like lld-link is > required (compile with -fuse-ld=lld-link on Clang). > ``` Perhaps `s/can't/don't/` to fix the same detail here? https://github.com/llvm/llvm-project/pull/145175 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
